-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGINT properly in the controller manager (backport #2014) #2040
Conversation
Cherry-pick of 882b489 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
14b9f9b
to
7292129
Compare
b00b8c6
to
3e0fefe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #2040 +/- ##
===========================================
- Coverage 87.00% 62.67% -24.34%
===========================================
Files 97 109 +12
Lines 7505 12641 +5136
Branches 677 8583 +7906
===========================================
+ Hits 6530 7923 +1393
- Misses 688 902 +214
- Partials 287 3816 +3529
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@urfeex when you have time, please test this branch and let us know if it works. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works just like on the Humble branch :-)
I am just wondering about the removed CONTROLLER_MANAGER_PUBLIC
macros.
b7c0f77
to
2d8fa81
Compare
resolves #2012
resolves #1168
resolves #472
Needed by ros-controls/ros2_control_demos#548
With example_1 of ros2_control_demos:
This is an automatic backport of pull request #2014 done by [Mergify](https://mergify.com).