Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong CM statistics + add fix for overruns #2042

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Feb 7, 2025

There is a bug in the CM statistics in the first loop, but then apart from that, when there is a controller that takes longer in the loop, this causes an overrun in the system. In order to fix it, I've added an overrun check and adjust the time properly to trigger the loops.

Earlier, the triggered overruns are the cause for such fast loops, resulting in high periodicity reports

Tested on real hardware TIAGo at 1kHz

image

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.38%. Comparing base (7406bdc) to head (55bdc45).

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 38.46% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
+ Coverage   89.35%   89.38%   +0.02%     
==========================================
  Files         138      138              
  Lines       14764    14767       +3     
  Branches     1270     1271       +1     
==========================================
+ Hits        13192    13199       +7     
+ Misses       1095     1094       -1     
+ Partials      477      474       -3     
Flag Coverage Δ
unittests 89.38% <38.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 56.06% <38.46%> (-7.10%) ⬇️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant