Skip to content

Commit

Permalink
Rename save_iterm to save_i_term
Browse files Browse the repository at this point in the history
  • Loading branch information
christophfroehlich committed Feb 13, 2025
1 parent 25e415d commit 4ab1e1a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion doc/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ mecanum_drive_controller
pid_controller
************************
* 🚀 The PID controller was added 🎉 (`#434 <https://github.com/ros-controls/ros2_controllers/pull/434>`_).
* Add ``save_iterm`` parameter to control retention of integral state after re-activation (`#1507 <https://github.com/ros-controls/ros2_controllers/pull/1507>`_).
* Add ``save_i_term`` parameter to control retention of integral state after re-activation (`#1507 <https://github.com/ros-controls/ros2_controllers/pull/1507>`_).

steering_controllers_library
********************************
Expand Down
2 changes: 1 addition & 1 deletion pid_controller/src/pid_controller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ controller_interface::CallbackReturn PidController::on_activate(
measured_state_values_.assign(
measured_state_values_.size(), std::numeric_limits<double>::quiet_NaN());

// prefixed save_iterm parameter is read from ROS parameters
// prefixed save_i_term parameter is read from ROS parameters
for (auto & pid : pids_)
{
pid->reset();
Expand Down
2 changes: 1 addition & 1 deletion pid_controller/src/pid_controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ pid_controller:
description: "For joints that wrap around (i.e., are continuous).
Normalizes position-error to -pi to pi."
}
save_iterm: {
save_i_term: {
type: bool,
default_value: true,
description: "Indicating if integral term is retained after re-activation"
Expand Down

0 comments on commit 4ab1e1a

Please sign in to comment.