Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency of admittance controller on JTC #1532

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Remove dependency of admittance controller on JTC #1532

merged 2 commits into from
Feb 12, 2025

Conversation

christophfroehlich
Copy link
Contributor

From @marip8 #1434

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Feb 11, 2025
@christophfroehlich christophfroehlich mentioned this pull request Feb 11, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (ae6efeb) to head (5b81ad0).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1532   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         123      123           
  Lines       11359    11359           
  Branches      961      961           
=======================================
  Hits         9573     9573           
  Misses       1470     1470           
  Partials      316      316
Flag Coverage Δ
unittests 84.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

saikishor
saikishor approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right to me :)

@bmagyar bmagyar merged commit e5562fb into master Feb 12, 2025
24 of 25 checks passed
@bmagyar bmagyar deleted the fix/admittance_deps branch February 12, 2025 18:48
mergify bot pushed a commit that referenced this pull request Feb 12, 2025
@christophfroehlich @mergify
Remove dependency of admittance controller on JTC (#1532)
34e0493 
Co-authored-by: Michael Ripperger <michael.ripperger@swri.org>
(cherry picked from commit e5562fb)
@mergify mergify bot mentioned this pull request Feb 12, 2025
Merged
christophfroehlich pushed a commit that referenced this pull request Feb 12, 2025
@mergify
Remove dependency of admittance controller on JTC (backport #1532) (#…
92c47bd 
…1537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@saikishor saikishor saikishor approved these changes

@anfemosa anfemosa Awaiting requested review from anfemosa

@aprotyas aprotyas Awaiting requested review from aprotyas

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@progtologist progtologist Awaiting requested review from progtologist

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophfroehlich @bmagyar @saikishor @marip8