Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rosdep file targeting with head_ref argument #16

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 19, 2024

When we're using head_ref, we should determine what rosdep files exist in the tree behind that ref, and not which files are present in the working directory.

When we're using `head_ref`, we should determine what rosdep files exist
in the tree behind that ref, and not which files are present in the
working directory.
@cottsay cottsay added the bug Something isn't working label Sep 19, 2024
@cottsay cottsay self-assigned this Sep 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 38.06%. Comparing base (5e0a145) to head (756231d).

Files with missing lines Patch % Lines
rosdistro_reviewer/element_analyzer/rosdep.py 0.00% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   39.10%   38.06%   -1.05%     
==========================================
  Files          12       12              
  Lines         583      599      +16     
  Branches      154      158       +4     
==========================================
  Hits          228      228              
- Misses        350      365      +15     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit 26290b5 into main Sep 20, 2024
18 checks passed
@cottsay cottsay deleted the cottsay/rosdep-file-list branch September 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants