not testing on foxy any more (#310)

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
ros · Jul 31, 2023 · 48db510 · 48db510
1 parent f67c4b2
commit 48db510
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -21,11 +21,9 @@ jobs:
             diagnostic_updater,
             self_test,
           ]
-        distro: [foxy, humble, rolling]
-        # distro: [foxy, humble, iron, rolling]
+        distro: [humble, rolling]
+        # distro: [humble, iron, rolling]
         include:
-          - distro: foxy
-            os: ubuntu-20.04
           - distro: humble
             os: ubuntu-22.04
           # - distro: iron

diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-[![Test diagnostics](https://img.shields.io/github/actions/workflow/status/ros/diagnostics/test.yaml?label=test&style=flat-square)](https://github.com/ros/diagnostics/actions/workflows/test.yaml) [![Lint diagnostics](https://img.shields.io/github/actions/workflow/status/ros/diagnostics/lint.yaml?label=lint&style=flat-square)](https://github.com/ros/diagnostics/actions/workflows/lint.yaml) [![ROS2 Foxy](https://img.shields.io/ros/v/foxy/diagnostics.svg?style=flat-square)](https://index.ros.org/r/diagnostics/#foxy) [![ROS2 Humble](https://img.shields.io/ros/v/humble/diagnostics.svg?style=flat-square)](https://index.ros.org/r/diagnostics/#humble) [![ROS2 Iron](https://img.shields.io/ros/v/iron/diagnostics.svg?style=flat-square)](https://index.ros.org/r/diagnostics/#iron) [![ROS2 Rolling](https://img.shields.io/ros/v/rolling/diagnostics.svg?style=flat-square)](https://index.ros.org/r/diagnostics/#rolling)
+[![Test diagnostics](https://img.shields.io/github/actions/workflow/status/ros/diagnostics/test.yaml?label=test&style=flat-square)](https://github.com/ros/diagnostics/actions/workflows/test.yaml) [![Lint diagnostics](https://img.shields.io/github/actions/workflow/status/ros/diagnostics/lint.yaml?label=lint&style=flat-square)](https://github.com/ros/diagnostics/actions/workflows/lint.yaml) [![ROS2 Humble](https://img.shields.io/ros/v/humble/diagnostics.svg?style=flat-square)](https://index.ros.org/r/diagnostics/#humble) [![ROS2 Iron](https://img.shields.io/ros/v/iron/diagnostics.svg?style=flat-square)](https://index.ros.org/r/diagnostics/#iron) [![ROS2 Rolling](https://img.shields.io/ros/v/rolling/diagnostics.svg?style=flat-square)](https://index.ros.org/r/diagnostics/#rolling)
 
 # Overview
 
@@ -36,7 +36,6 @@ Diagnostics messages that are not aggregated can be visualized by [`rqt_runtime_
 
 The [`ros2` branch](https://github.com/ros/diagnostics/tree/ros2) targets
 
-- *Foxy Fitzroy*,
 - *Humble Hawksbill*
 - *Iron Irwini* and
 - *Rolling Ridley*

diff --git a/diagnostic_common_diagnostics/test/systemtest/test_ntp_monitor.py b/diagnostic_common_diagnostics/test/systemtest/test_ntp_monitor.py
@@ -102,6 +102,12 @@ def _count_msgs(self, timeout_s):
         return self.n_msgs_received
 
     def test_publishing(self):
+        self.assertEqual(
+            self.subprocess.poll(),
+            None,
+            'NTP monitor subprocess died'
+        )
+
         n = self._count_msgs(TIMEOUT_MAX_S)
 
         self.assertGreater(