Implement action recording and display info about recorded action #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Barry-Xu-2018 thanks 👍 please let us know once this is ready to review. |
|
CC: @MichaelOrlov |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
force-pushed
the
reivew/topic-support-action-record-and-info
branch
from
3b18d88 to
83b0d07
Compare
Okay. I will notify you once it's ready. |
|
Although the design (#1928) is still being finalized, there are no objections regarding the record and info sections, so I have implemented these parts according to the design. If you have time, please help review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address ros-infrastructure/rep#405
Design #1928