Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize filter with namespaced updated topics and services. (jazzy) #1943

Closed
wants to merge 2 commits into from
Closed

Initialize filter with namespaced updated topics and services. (jazzy) #1943

wants to merge 2 commits into from

Conversation

rodericktaylor
Copy link
Contributor

Fixes #1942

@rodericktaylor
Initialize filter with namespaced updated topics.
bdaffe0 
Signed-off-by: Rod Taylor <rod.taylor@csiro.au>
@rodericktaylor rodericktaylor requested a review from a team as a code owner March 20, 2025 07:26
@rodericktaylor rodericktaylor requested review from MichaelOrlov and hidmic and removed request for a team March 20, 2025 07:26
fujitatomoya
fujitatomoya reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating TopicFilter after expanding the topic and service names sounds right thing to do here for me.

@fujitatomoya
Copy link
Contributor

@rodericktaylor btw, can you target this PR to rolling branch. we do usually fixes and development in rolling branch 1st, and then backport the fixes to released distros such as jazzy and humble.

@rodericktaylor rodericktaylor changed the title Initialize filter with namespaced updated topics and services. Initialize filter with namespaced updated topics and services. (jazzy) Mar 21, 2025
@rodericktaylor
Revert using options member instead of argument.
9d1e4c2 
Signed-off-by: Rod Taylor <rod.taylor@csiro.au>
@rodericktaylor
Copy link
Contributor Author

@rodericktaylor btw, can you target this PR to rolling branch. we do usually fixes and development in rolling branch 1st, and then backport the fixes to released distros such as jazzy and humble.

I have created a pull request for the rolling branch.

@fujitatomoya
Copy link
Contributor

@rodericktaylor i think you can close this one, we use mergify to backports.

@rodericktaylor
Copy link
Contributor Author

Changes to rolling should be backported to the jazzy branch. Closing.

@rodericktaylor rodericktaylor deleted the fix_relative_topics branch March 21, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodericktaylor @fujitatomoya