Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize filter with namespaced updated topics and services. (rolling) #1944

Merged
merged 2 commits into from
Mar 24, 2025
+3 −2
Merged

Initialize filter with namespaced updated topics and services. (rolling) #1944

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af149fe
Initialize filter with namespaced updated topics.
rodericktaylor Mar 20, 2025
9924fb1
Revert using options member instead of argument.
rodericktaylor Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rosbag2_transport/src/rosbag2_transport/recorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ RecorderImpl::RecorderImpl(
"use_sim_time and is_discovery_disabled both set, but are incompatible settings. "
"The /clock topic needs to be discovered to record with sim time.");
}
if (!record_options.disable_keyboard_controls) {
if (!record_options_.disable_keyboard_controls) {
std::string key_str = enum_key_code_to_str(Recorder::kPauseResumeToggleKey);
toggle_paused_key_callback_handle_ =
keyboard_handler_->add_key_press_callback(
Expand All @@ -191,7 +191,6 @@ RecorderImpl::RecorderImpl(
node->get_logger(),
"Press " << key_str << " for pausing/resuming");
}
topic_filter_ = std::make_unique<TopicFilter>(record_options, node->get_node_graph_interface());

for (auto & topic : record_options_.topics) {
topic = rclcpp::expand_topic_or_service_name(
Expand All @@ -216,6 +215,8 @@ RecorderImpl::RecorderImpl(
exclude_service_event_topic, node->get_name(),
node->get_namespace(), false);
}

topic_filter_ = std::make_unique<TopicFilter>(record_options_, node->get_node_graph_interface());
}

RecorderImpl::~RecorderImpl()
Expand Down
Loading