Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 add exercises #24

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: 📝 add exercises #24

wants to merge 5 commits into from

Conversation

signekb
Copy link
Member

@signekb signekb commented Jan 19, 2025

Description

This PR adds exercises. Somehow, it ended up with four exercises, which might be too much. What do you think?

Related to #10

This PR needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

sessions/lesson.qmd Outdated Show resolved Hide resolved
sessions/lesson.qmd Outdated Show resolved Hide resolved
Comment on lines 25 to 40
First, we want to add a file to the repository.

1. Go to the repository on GitHub.
2. In the code tab, click "Add file" and then "Create new file".
3. In the "Name your file..." field, type a name for your file. For
simplicity, let's call it your name and make it a Markdown file. For
example, "your-name.md".
4. Click the green "Commit changes" button and fill in the commit
message. For example, "Add file with my name". You don't need to
fill in the extended description. Keep the "Commit directly to the
`main` branch" option selected.
5. When you have filled in the commit message, click the green "Commit
changes" button.
6. Go back to the repository and check that your file has been added.

You have now made your first commit to the repository! :tada:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be a part of the code along instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, these steps could be, but the basic steps can stay the same. See comment above about "problem to solve"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I have kept everything as exercises. Then we can move them to the different lessons and change them accordingly there.

Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start! Some comments ☺️

Comment on lines 23 to 25
## Exercise: Add a new file and modify the content

First, we want to add a file to the repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the format of the vscode snippet exercise to match the other websites ☺️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It helps that exercises have some problem to solve rather than "do this", "but why", "because". Maybe it could be like the exercises you thought of for git4cats, where we get them to find a recipe they like and put it on the repo as a new file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone all out with the recipes / recipe book now 🍰 🍪

sessions/lesson.qmd Outdated Show resolved Hide resolved
sessions/lesson.qmd Outdated Show resolved Hide resolved
Comment on lines 25 to 40
First, we want to add a file to the repository.

1. Go to the repository on GitHub.
2. In the code tab, click "Add file" and then "Create new file".
3. In the "Name your file..." field, type a name for your file. For
simplicity, let's call it your name and make it a Markdown file. For
example, "your-name.md".
4. Click the green "Commit changes" button and fill in the commit
message. For example, "Add file with my name". You don't need to
fill in the extended description. Keep the "Commit directly to the
`main` branch" option selected.
5. When you have filled in the commit message, click the green "Commit
changes" button.
6. Go back to the repository and check that your file has been added.

You have now made your first commit to the repository! :tada:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, these steps could be, but the basic steps can stay the same. See comment above about "problem to solve"

sessions/lesson.qmd Outdated Show resolved Hide resolved
sessions/lesson.qmd Outdated Show resolved Hide resolved
sessions/lesson.qmd Outdated Show resolved Hide resolved
sessions/lesson.qmd Outdated Show resolved Hide resolved
@signekb signekb requested a review from lwjohnst86 February 14, 2025 13:47
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! I've made lots of suggestions 😁 🎉

@@ -20,7 +20,285 @@ Specific learning objectives are:
TODO: Reading text
:::

## Exercise: TODO: Add title
## :woman_technologist: Exercise: Add a cookie recipe to the repository {#sec-add-recipe-file}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## :woman_technologist: Exercise: Add a cookie recipe to the repository {#sec-add-recipe-file}
## :woman_technologist: Exercise: Add a cookie recipe to your repository

It isn't necessary to add the sec tags unless you reference them elsewhere. Which we generally don't


{{< text_snippet sticky_up >}}

## :technologist: Exercise: Add the cookie recipe to `cookie-recipe.md` file {#sec-add-recipe-content}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## :technologist: Exercise: Add the cookie recipe to `cookie-recipe.md` file {#sec-add-recipe-content}
## :technologist: Exercise: Add the cookie recipe to `cookie-recipe.md` file

Let's add the first recipe to your repository: A cookie recipe! :cookie:

First, we want to add a file that will include the recipe to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
First, we want to add a file that will include the recipe to the
First, we want to add a file that will include the recipe to your

First, we want to add a file that will include the recipe to the
repository.

1. Go to the repository on GitHub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Go to the repository on GitHub.

repository.

1. Go to the repository on GitHub.
2. In the code tab, click "Add file" and then "Create new file".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. In the code tab, click "Add file" and then "Create new file".
1. In the "Code" tab of your repository, click "Add file" and then "Create new file".

Comment on lines +221 to +228
::: {.callout-note collapse="true"}
## :teacher: Instructor note

Before starting this exercise, make sure that the learners have added
their neighbour as collaborators to their repositories. If they haven't,
they can do so by going to the repository, clicking on "Settings", then
"Collaborators and teams", and then "Add people".
:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a task in the exercise, depending on how the content before is structured. For now, this is good!

Comment on lines +234 to +237
2. As we did in @sec-add-recipe-file and @sec-add-recipe-content , add
a new file with a recipe - this time, it's just in another person's
repository. For example, you could add a brownie recipe like the one
below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. As we did in @sec-add-recipe-file and @sec-add-recipe-content , add
a new file with a recipe - this time, it's just in another person's
repository. For example, you could add a brownie recipe like the one
below:
2. As we've done during this workshop, add
a new file with a recipe, naming the file by using the recipe name (remember the correct naming for files!).
This time, you will be adding the file to your
neighbour's repository. In the file, add a recipe of your choice.
For convenience, you can also use the brownie recipe below:

5. Pour the mixture into a baking tray and bake at 170°C for 30-35 minutes.
```

3. Commit the changes as we have done it previously and go to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Commit the changes as we have done it previously and go to the
3. Commit the changes as you have done previously in the workshop. Then go to the neighbour's

Comment on lines +266 to +274
## :woman_technologist: Exercise: See the changes in the repository

> Time: \~10 minutes.

After you have made the changes, go back to the repository and click the
History button to see the changes that have been made (including your
own and the changes made by others).

{{< text_snippet sticky_up >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure this is necessary as an exercise. Unless it is re-written to be about a problem/finding something. We already have lots of exercises, so I think it's fine to delete.

Suggested change
## :woman_technologist: Exercise: See the changes in the repository
> Time: \~10 minutes.
After you have made the changes, go back to the repository and click the
History button to see the changes that have been made (including your
own and the changes made by others).
{{< text_snippet sticky_up >}}

Comment on lines +276 to +301
## :woman_technologist: Exercise: Cleaning up

> Time: \~10 minutes.

Now, let's close the "Future recipes" issue you created earlier.

1. Go to the "Issues" tab in your repository.
2. Click on the issue you created.
3. In the comment field, write a comment about why you are closing the
issue. For example, you could write "This issue has been resolved"
or "I have now added all the relevant recipes from this issue".
Then, click the "Close issue" button.

Lastly, let's delete the `chocolate-chip-cookies.md` file along with the
`cookies` folder you created earlier:

1. Go to the file.
2. On the same line as the file name, click the button with the three
dots, saying "More file actions". Click it, scroll down and click
"Delete file".
3. Commit the changes.
4. Now, go the `cookies` folder and delete it in the same way as you
deleted the `chocolate-chip-cookies.md` file. For folders, it will
say "Delete directory" instead of "Delete file".

{{< text_snippet sticky_up >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## :woman_technologist: Exercise: Cleaning up
> Time: \~10 minutes.
Now, let's close the "Future recipes" issue you created earlier.
1. Go to the "Issues" tab in your repository.
2. Click on the issue you created.
3. In the comment field, write a comment about why you are closing the
issue. For example, you could write "This issue has been resolved"
or "I have now added all the relevant recipes from this issue".
Then, click the "Close issue" button.
Lastly, let's delete the `chocolate-chip-cookies.md` file along with the
`cookies` folder you created earlier:
1. Go to the file.
2. On the same line as the file name, click the button with the three
dots, saying "More file actions". Click it, scroll down and click
"Delete file".
3. Commit the changes.
4. Now, go the `cookies` folder and delete it in the same way as you
deleted the `chocolate-chip-cookies.md` file. For folders, it will
say "Delete directory" instead of "Delete file".
{{< text_snippet sticky_up >}}

Given we already have lots of exercises, and that this is a low priority/low value exercise, let's just delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants