fix: backspace and delete shortcuts on macos #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfsxreloader
requested review from
bernardobelchior,
canastro,
RafaelSeSouza and
victorbotamedi
Comment on lines
45
to
46
| "Delete" : NSDeleteCharacter, | ||
| "Backspace" : NSBackspaceCharacter |
There was a problem hiding this comment.
Are there any other special shortcuts that we may need to add here?
There was a problem hiding this comment.
probably, but I don't know every single one that is necessary
There was a problem hiding this comment.
From a quick search, these seems to be available, but I'm not sure which ones are valid values for a context menu shortcut.
There was a problem hiding this comment.
there are more such at this ones for example, I can try to add a bit more
There was a problem hiding this comment.
For completeness sake, that would be nice. It can also be done in a follow-up PR. As you prefer 👍
bernardobelchior
approved these changes
May 13, 2022
bernardobelchior
approved these changes
May 13, 2022
RafaelSeSouza
approved these changes
May 13, 2022
canastro
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #14