Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cchalf use unweighted pearson #181

Merged
merged 3 commits into from
Feb 3, 2025
Merged

make cchalf use unweighted pearson #181

merged 3 commits into from
Feb 3, 2025

Conversation

kmdalton
Copy link
Member

@kmdalton kmdalton commented Feb 3, 2025

Following a discussion with Kay Diederichs on the rs-station forum, careless should use the unweighted Pearson correlation coefficient for CChalf. I'm making this the default with an option to use a weighted variant. All CC stats CLI programs now will take 'weighted', 'pearson', or 'spearman' for the --method flag. The defaults are set as follows

  • cchalf : pearson
  • ccanom : weighted
  • ccpred : weighted
  • image_ccpred : weighted
  • filter_image : weighted

@kmdalton kmdalton merged commit 26c5fad into main Feb 3, 2025
4 checks passed
@kmdalton kmdalton deleted the cchalf branch February 3, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant