Faster parser for CrystFEL stream files

[kmdalton]

I wrote a faster version of the stream file parser. It mostly just uses more numpy and less pandas while vectorizing operations within a crystal block.

[codecov-commenter]

Codecov Report

Merging #216 (d0ee0d6) into main (859e75c) will decrease coverage by 1.81%.
The diff coverage is 74.39%.

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   98.39%   96.58%   -1.81%     
==========================================
  Files          45       45              
  Lines        1803     1845      +42     
==========================================
+ Hits         1774     1782       +8     
- Misses         29       63      +34     

Flag	Coverage Δ
unittests	96.58% <74.39%> (-1.81%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
reciprocalspaceship/io/crystfel.py	75.86% <74.39%> (-18.84%)	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DHekstra]

Does this/could this also address #213 ?

[kmdalton]

@DHekstra , i don't know if the information you want is available in the stream file. i would need to see an example.

[JBGreisman]

This looks pretty good to me, but I'll do another look through before approving/merging.

[JBGreisman]

I think this looks good to me-- feel free to merge if you think it is ready to go.

[kmdalton]

There are a couple of issues that still need to be addressed

1. Doeke provided me some more recent stream files, and they seem to break some of my formatting assumptions.
2. The current version doesn't respect that some files have the photon energy measured per frame. My code just uses the photon energy in the header for every crystal. This is a problem for XFEL data where the peak energy changes from shot to shot.

I'm going to hold off until I have a bit more time to look through it.

[DHekstra]

@kmdalton, what is the status of this? I'm revisiting some stream files next week, and could test drive your parser.

[kmdalton]

I was not able to parse some stream files @DHekstra gave me. There are some formatting differences between stream files that I haven't accounted for. I'm unlikely to have time to finish this soon.

[DHekstra]

that's alright. I have a slow but functional parser.

[JBGreisman]

Just checking in here -- is there anything left to do on this PR or should it be merged into main?

[kmdalton]

I discovered this version in was incompatible with some stream files provided by @DHekstra. I haven't been able to diagnose the issue yet. I would recommend we hold off on merging.

[JBGreisman]

Does this need to be merged anymore? Or will this be superseded by #260 ?

[kmdalton]

superseded by #260