Deprecated DataSet.to_reciprocalgrid() should call DataSet.to_reciprocal_grid()
#285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 88.98% 88.93% -0.05%
==========================================
Files 40 40
Lines 2841 2830 -11
==========================================
- Hits 2528 2517 -11
Misses 313 313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmdalton
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor bookkeeping PR -- we currently have two function for converting a
DataSetto a 3D numpy array representing the underlying data:DataSet.to_reciprocalgrid()andDataSet.to_reciprocal_grid(). The former will be deprecated in favor of the latter, in order to have consistency naming schemes in terms of underscores.However, we currently have duplicate implementations for both functions. If we want to edit the implementations before we officially remove one of them, we will need to make changes in both places. This PR updates the deprecated code to call the newer version to avoid needing to maintain the code in two places.