Use the v1 vanity API #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tdstein
approved these changes
Jun 21, 2024
Comment on lines
+114
to
+117
| public async setContentVanityURL (contentGUID: string, vanityURL: string): Promise<VanityRecordResponse> { | ||
| return await this.client.put( | ||
| `v1/content/${contentGUID}/vanity`, | ||
| { path: vanityURL } |
There was a problem hiding this comment.
Very nit, but it should be... based on convention
Suggested change
| public async setContentVanityURL (contentGUID: string, vanityURL: string): Promise<VanityRecordResponse> { | |
| return await this.client.put( | |
| `v1/content/${contentGUID}/vanity`, | |
| { path: vanityURL } | |
| public async setContentVanityURL (contentGuid: string, vanityUrl: string): Promise<VanityRecordResponse> { | |
| return await this.client.put( | |
| `v1/content/${contentGuid}/vanity`, | |
| { path: vanityUrl } |
There was a problem hiding this comment.
Local convention uses names like baseURL and already used vanityURL. There are a couple "GUID" references and they're appGuid, but many appID. I did not notice the appGuid and thought I was following convention by uppercasing initialisms (URL, GUID).
@meatballhat - do you have a preference on naming convention?
There was a problem hiding this comment.
Ah, no worries then. Should keep it as is if the rest of the project is using that by convention.
available in all supported Connect versions
aronatkins
force-pushed
the
aron-v1-vanity
branch
from
80b20c5 to
a02dd24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #30 (for passing CI)
The v1 vanity API is available in all supported Connect versions. No need to fall-back to the unversioned API path.
Fixes #29