-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Refactor] Reorganization of BERTrend code #17
Merged
grosjeang
merged 49 commits into
main
from
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
Jan 10, 2025
Merged
[WIP] [Refactor] Reorganization of BERTrend code #17
grosjeang
merged 49 commits into
main
from
14-refactor-make-a-independent-bertrend-class-to-simplify-usage-and-integration
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TopicModel class to encapsulate initialization and calls to topic models (BERTopic) - BERTrend class to encapsulate the main steps of the BERTrend algorithm - bertrend.toml config to configurate Embedding and LLM services - EmbeddingService to decide between local and remote embeddings - some tests (to be completed) - reorganization of files
- finalized LLM service configuration
2 tasks
e4c6a96
to
08752e3
Compare
228abb9
to
10cf9a5
Compare
96d393d
to
8a3c057
Compare
8e443f7
to
f78328d
Compare
bee0120
to
004fac9
Compare
004fac9
to
12eed54
Compare
fdda807
to
8a916af
Compare
f3b405e
to
4b44aca
Compare
169b9aa
to
020a994
Compare
51c7125
to
8c1c142
Compare
8c1c142
to
ccef0f4
Compare
4fa8ee0
to
9c73d7f
Compare
9c73d7f
to
7c1d5dc
Compare
5476d46
to
cee8d5a
Compare
cee8d5a
to
fc17eeb
Compare
2 tasks
71b9606
to
2469952
Compare
d500a17
to
97ddefb
Compare
9f556d7
to
55286ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized code structure
TopicModel class to encapsulate initialization and calls to topic models (BERTopic)
BERTrend class to encapsulate the main steps of the BERTrend algorithm
bertrend.toml config to configurate Embedding and LLM services
EmbeddingService to decide between local and remote embeddings
Configuration of LLM service
some tests (to be completed)
Replaced configparser with toml files
Harmonization of data loading between prototypes and possibility to load local data
Refactoring demo 1 (topic analysis)
Admin mode to show/hide some parameters and results
Code cleaning
Adaptation of topic-based newsletter generation
more to come...