Split out Component binaries into @ruby/wasm-wasip2 package
#528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@ruby/wasm-wasi` package included both the Core Module and the Component binaries but it has two problems: 1. npm package size was too large and it was very close to the limit of the jsdelivr CDN. 2. The Component model build (in other words, dynamic linking build) well supports incremental build. But the Core Module build does not because it requires to re-link C-extensions every time statically. And it led to clean build every time. Splitting out the Component build makes the p2 package itself incremental buildable.
…s private I'm not confident that the name of the package, `@ruby/head-wasm-wasip2`, is the best name for the package. So I'm marking it as private for now.
kateinoigakukun
force-pushed
the
katei/add-wasip2-pkg
branch
from
edd78ea to
338fcee
Compare
This reverts commit 54ff9a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@ruby/head-wasm-wasipackage included both the Core Module and the Componentbinaries but it has two problems:
the jsdelivr CDN.
well supports incremental build. But the Core Module build does not
because it requires to re-link C-extensions every time statically.
And it led to clean build every time. Splitting out the Component
build makes the p2 package itself incremental buildable.