Add package size validation to Item model and update form input

rubyforgood · Feb 25, 2025 · 33c3191 · 33c3191
1 parent d73c67a
commit 33c3191
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/app/models/item.rb b/app/models/item.rb
@@ -41,6 +41,7 @@ class Item < ApplicationRecord
   validates :distribution_quantity, numericality: { greater_than: 0 }, allow_blank: true
   validates :on_hand_recommended_quantity, numericality: { greater_than_or_equal_to: 0 }, allow_blank: true
   validates :on_hand_minimum_quantity, numericality: { greater_than_or_equal_to: 0 }
+  validates :package_size, numericality: { greater_than_or_equal_to: 0 }, allow_blank: true
 
   has_many :line_items, dependent: :destroy
   has_many :inventory_items, dependent: :destroy

diff --git a/app/views/items/_form.html.erb b/app/views/items/_form.html.erb
@@ -40,7 +40,7 @@
               <% end %>
 
               <%= f.input :name, label: "Package size", wrapper: :input_group do %>
-                <%= f.input_field :package_size, class: "form-control" %>
+                <%= f.input_field :package_size, class: "form-control", min: 0 %>
               <% end %>
 
               <% if Flipper.enabled?(:enable_packs) %>

diff --git a/spec/models/item_spec.rb b/spec/models/item_spec.rb
@@ -41,6 +41,7 @@
     it { should validate_numericality_of(:on_hand_minimum_quantity).is_greater_than_or_equal_to(0) }
     it { should validate_numericality_of(:on_hand_recommended_quantity).is_greater_than_or_equal_to(0) }
     it { should validate_length_of(:additional_info).is_at_most(500) }
+    it { should validate_numericality_of(:package_size).is_greater_than_or_equal_to(0) }
   end
 
   context "Filtering >" do