Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elasticsearch 8.10 - 8.12 to pipeline #2191

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

sidz
Copy link
Contributor

@sidz sidz commented Jan 28, 2024

This PR adds testing against Elasticsearch versions:

  • 8.10
  • 8.11
  • 8.12

Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pains me a bit that we have to test against so many versions. It helps to debug issues quickly in which version it broken. Eventually we can thin it out to have oldest (8.0.0) and newest 2 tested or similar to speed up CI time.

experimental: false
- php: '8.1'
elasticsearch: '8.9.0-SNAPSHOT' # future version, allow to fail https://www.elastic.co/guide/en/elasticsearch/reference/master/release-notes-8.9.0.html
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove SNAPSHOT on purpose? For example there is now 8.13.0-SNAPSHOT.

I'm ok with removing it at the moment as development is not as quick on Elastica and removing it means more stable builds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to check is 8.13-SNAPSHOT exists or not. That's why I didn't add it.

Eventually we can thin it out to have oldest (8.0.0) and newest 2 tested or similar to speed up CI time.

Makes sense.

@ruflin ruflin merged commit 87e7caa into ruflin:8.x Jan 29, 2024
18 checks passed
@sidz sidz deleted the test-against-latest-elasticsearch-versions branch January 29, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants