Update README.md 7X. 8.X changes #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidz
reviewed
Mar 6, 2024
README.md
Outdated
| @@ -35,7 +35,8 @@ It is generally recommended to use the latest point release of the relevant bran | |||
|
|
|||
| | Elastica branch | ElasticSearch | elasticsearch-php | PHP | | |||
| | ----------------------------------------------------- | ------------- | ----------------- | -------------- | | |||
| | [7.x](https://github.com/ruflin/Elastica/tree/master) | 7.x | ^7.0 | ^7.2 \|\| ^8.0 | | |||
| | [8.x](https://github.com/ruflin/Elastica/tree/master) | 8.x | ^8.4 | >=8.0 <8.2 | |||
There was a problem hiding this comment.
The right link to 8.x branch is https://github.com/ruflin/Elastica/tree/8.x
There was a problem hiding this comment.
@sidz Thank you for your feedback, I made this change based on the history of changes in the README during which I noted that the last version was systematically positioned on the master branch which itself is an alias which points to the branch of the latest version. I took this to be a convention. I misunderstand ?
There was a problem hiding this comment.
There was a recent change around 8.x where we renamed master to 8.x. There is no master branch anymore.
ruflin
approved these changes
Mar 7, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated datatable release
move 7.X bad link and add 8.x based on CHANGELOG, COMPOSER.JSON review