Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the issue with the link redirecting to a 422: Unprocessable Entity #13408

Closed
wants to merge 1 commit into from

Conversation

gSayak
Copy link

@gSayak gSayak commented Feb 6, 2024

What does this PR try to resolve?

This PR solves issue #13407

There is an issue with the readme.md where if you check the Code-of-conduct tab in the readme and click on the can be found online link, it redirects to a 422: Unprocessable Entity. Fixed this by changing the link to the actual code-of-conduct link.

How should we test and review this PR?

To test this PR, go to the readme.md file in the PR and click on the link of can be found online, it would redirect to the correct webpage.

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2024
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

While this does resolve the issue, I am not sure since when the link is broken. We might want to reach out to https://github.com/rust-lang/www.rust-lang.org/ to have a redirection.

@gSayak
Copy link
Author

gSayak commented Feb 6, 2024

I see, I thought the Code of Conduct link was moved to a different link and it was not updated in the readme.
Will we need to fix it in the www.rust-lang.org repo?

@weihanglo
Copy link
Member

The old link was used in pre 2018 website: https://prev.rust-lang.org/conduct.html. And here are redirection rules. I am not sure why it didn't work. Maybe something wrong when upgrading Rocket to v0.5? We can clone the repo and debug there.

Since this link is used in a couple of different repository (rust-lang/rust, rust-lang/rust-clippy, …), I lean towards fixing in the redirection. If we cannot find the root cause, then contact Manishearth as they are the only member on the website team.

@gSayak
Copy link
Author

gSayak commented Feb 7, 2024

Okay then, I will try to fix this redirection issue and give an update here

@weihanglo
Copy link
Member

Close as fixed in rust-lang/www.rust-lang.org#1924. Regardless, thanks for your help :)

@weihanglo weihanglo closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants