Ergonomic ref counting #134797
Merged
Ergonomic ref counting #134797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
spastorino
force-pushed
the
ergonomic-ref-counting-1
branch
from
e4e8ad3 to
b003b20
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
ergonomic-ref-counting-1
branch
from
b003b20 to
94d4dde
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
ergonomic-ref-counting-1
branch
from
42e6956 to
0aaedb8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
ergonomic-ref-counting-1
branch
from
f9a2abe to
0c29a0b
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
ergonomic-ref-counting-1
branch
from
0c29a0b to
b82e779
Compare
nikomatsakis
requested changes
Dec 27, 2024
rustbot
added
S-waiting-on-author
|
I've pushed some tests and I've found some parsing errors, a diagnostic ICE and another issue that needs handling during borrowck. CI is going to be red but is fine as this is not yet done. |
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Dec 29, 2024
spastorino
force-pushed
the
ergonomic-ref-counting-1
branch
from
2737662 to
a5cb5f9
Compare
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in cc @BoxyUwU Some changes occurred in match checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@nikomatsakis I'm going to do some further reviews, probably add some more tests, add comments, etc, etc but would leave this up for review as it is "almost" done. |
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Feb 20, 2025
spastorino
force-pushed
the
ergonomic-ref-counting-1
branch
from
28beb7c to
d7104dc
Compare
nikomatsakis
approved these changes
Mar 6, 2025
|
@bors r=nikomatsakis |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2025
…1, r=nikomatsakis Ergonomic ref counting This is an experimental first version of ergonomic ref counting. This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations. RFC: rust-lang/rfcs#3680 Tracking issue: rust-lang#132290 Project goal: rust-lang/rust-project-goals#107 r? `@nikomatsakis`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2025
…1, r=nikomatsakis Ergonomic ref counting This is an experimental first version of ergonomic ref counting. This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations. RFC: rust-lang/rfcs#3680 Tracking issue: rust-lang#132290 Project goal: rust-lang/rust-project-goals#107 r? ``@nikomatsakis``
This was referenced Mar 7, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134797 (Ergonomic ref counting) - rust-lang#137549 (Clean up various LLVM FFI things in codegen_llvm) - rust-lang#137977 (Reduce `kw::Empty` usage, part 1) - rust-lang#138042 (Suggest struct or union to add generic that impls trait) - rust-lang#138141 (tests: fix some typos in comment) - rust-lang#138150 (Streamline HIR intravisit `visit_id` calls for items) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Rollup merge of rust-lang#134797 - spastorino:ergonomic-ref-counting-1, r=nikomatsakis Ergonomic ref counting This is an experimental first version of ergonomic ref counting. This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations. RFC: rust-lang/rfcs#3680 Tracking issue: rust-lang#132290 Project goal: rust-lang/rust-project-goals#107 r? ```@nikomatsakis```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental first version of ergonomic ref counting.
This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.
RFC: rust-lang/rfcs#3680
Tracking issue: #132290
Project goal: rust-lang/rust-project-goals#107
r? @nikomatsakis