Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using latest release where -f checks all local links #2254

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Feb 14, 2025

CC: @camelid

Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camelid camelid merged commit 5aff120 into rust-lang:master Feb 15, 2025
1 check passed
@marxin marxin deleted the start-using-latest-linkcheck2 branch February 15, 2025 22:04
@camelid
Copy link
Member

camelid commented Feb 15, 2025

FYI, the new description for the -f flag isn't the clearest imho:

Check web links only the given files (check all files if omitted).

I wouldn't know what this means if we hadn't discussed it before. Might be better to say something like:

Limit checking of web links to only the given files (check all files if omitted). Internal links to other Markdown files are always checked in all files, even when this flag is passed.

@marxin
Copy link
Contributor Author

marxin commented Feb 16, 2025

Sure, very good point, fixed in the next release: #2257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants