-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace references to RLS with rust-analyzer #1620
Conversation
DO_NOT_SUBMIT includes placeholders indicating places where appropriate translations are needed.
@@ -6,7 +6,7 @@ tools-editor-support-heading = First-class editor support | |||
tools-editor-support-description = Whether you prefer working with code from the | |||
command line, or using rich graphical editors, there’s a Rust | |||
integration available for your editor of choice. Or you can build your | |||
own using the <a href="https://github.com/rust-lang/rls">Rust Language Server</a>. | |||
own using the <a href="https://github.com/rust-analyzer/rust-analyzer">Rust Analyzer</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says, "the Rust Analyzer"
@@ -4,7 +4,7 @@ governance-team-wg-nll-description = Implémenter le nouveau « borrow checker | |||
governance-team-community-survey-name = Sondages | |||
governance-team-community-survey-description = Mener, analyser et présenter les sondages de la communauté | |||
governance-team-ides-name = Équipe éditeurs et EDIs | |||
governance-team-ides-description = Développer les EDIs, les éditeurs, et d'autres outils tels que Racer ou RLS (Rust Language Server) | |||
governance-team-ides-description = Développer les EDIs, les éditeurs, et d'autres outils tels que Racer ou RLS (Rust Analyzer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
governance-team-ides-description = Développer les EDIs, les éditeurs, et d'autres outils tels que Racer ou RLS (Rust Analyzer) | |
governance-team-ides-description = Développer les EDIs, les éditeurs, et d'autres outils tels que Racer ou Rust Analyzer |
My current understanding of the situation: #1242 (comment) |
@matklad What about mentioning that a transition to Rust Analyzer is in progress without necessarily making it the official recommendation and updating all the links immediately? e.g. a notice right at the top of the page with a condensed version of exactly the same points you just mentioned. I feel like something ought to be done. Official or not, RLS is effectively unmaintained, there has been only a few commits in the past year which are not merely bumping dependency versions. And there's a fairly constant stream of newbies in the Discord channels who get frustrated with RLS and then come to find out that all the people "in the know" are all using something different. That's not a great experience or first impression either. It's understandable that the organizational infrastructure and such would take a while to put in place, but I feel like new Rust users would be better served by knowing what options exist even if RA can't be the official recommendation yet. |
This does sound much better than the status quo to me personally, but I am a wrong person to ask about this, as I think I don't have authority over what we say on the website. |
Now that https://blog.rust-lang.org/2022/02/21/rust-analyzer-joins-rust-org.html has happened, is it possible to merge this? |
@matklad are you okay with this being merged? I am from my side. |
okay would be an understatement! :) |
Inspired by this Reddit comment and the RFC to make rust-analyzer the official LSP implementation. I couldn't find anywhere in the RFC where it called out exactly which point we'd start advertising rust-analyzer to new users, but I think we're already at a point where it is usually what folks want. Feel free to close if this isn't wanted, or if I'm skipping a step in the plan!
This PR currently includes DO_NOT_SUBMIT placeholders indicating places where
appropriate translations are needed. I unfortunately am not familiar with any of these languages and am not familiar with the current process for requesting translations. I did notice that only some languages are translating "Rust Language Server" into "Rust " today, and have only added DO_NOT_SUBMIT on those translations which were previously using something other than "Rust Language Server."