Deploy #1917
Merged
Deploy #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identify Linux riscv64 as unix
Denying all warnings for test builds results in a poor development experience, as everying always appears as an error in the editor. The program might still compile and run fine though. At the same time, CI only denies rustc's warnings, not those of clippy. So code that gets marked as an error in an editor can still pass CI. Both of these issues are fixed by running clippy in CI explicitly.
Update rocket to 0.5
Fix clippy config
doc(zh-CN): Fix reference to rust-analyzer in tools.ftl
Render custom roles
warning: accessing first element with `values.get(0)`
--> src/i18n.rs:20:31
|
20 | let email = match values.get(0) {
| ^^^^^^^^^^^^^ help: try: `values.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
warning: accessing first element with `values.get(0)`
--> src/i18n.rs:30:30
|
30 | let text = match values.get(0) {
| ^^^^^^^^^^^^^ help: try: `values.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
Resolve Rust 1.75's new get_first clippy lint
GET /governance/teams/leadership-council text/html:
>> Matched: (team) GET /governance/<section>/<team> [2]
>> Note: Using `String` as a parameter type is inefficient. Use `&str` instead.
>> `String` is used a parameter guard in src/main.rs:224.
>> Note: Using `String` as a parameter type is inefficient. Use `&str` instead.
>> `String` is used a parameter guard in src/main.rs:225.
>> Outcome: Success(200 OK)
GET /tools/install text/html:
>> Matched: (subject) GET /<category>/<subject> [4]
>> Note: Using `String` as a parameter type is inefficient. Use `&str` instead.
>> `String` is used a parameter guard in src/main.rs:260.
>> Outcome: Success(200 OK)
Fix warnings printed by Rocket regarding String as parameter type
Regenerate en-US teams.ftl from team repo
Use Rust 1.75's async fn in trait instead of #[async_trait]
Install current stable Rust in CI
Delete Atom editor
Handle launching-pad subteams.
Update Eclipse editor landing page
Delete Geany from editors list, add Visual Studio
Rename RustRover ftl key from `tools-editor-idea` to `tools-editor-rover`
Add fallback for role descriptions
|
Staging is currently broken, unfortunately. I cannot figure out why, the logs show a succesfull build but Heroku says the build failed. It does seem like the deploy did actually succeed given the Visual Studio stuff is visible. Not doing a deploy until someone figures out what's going on. cc @rust-lang/infra |
|
https://github.com/rust-lang/www.rust-lang.org/deployments/rust-www-staging |
|
sweet |
Thompson1985
approved these changes
Sep 28, 2024
Thompson1985
approved these changes
Sep 28, 2024
Thompson1985
approved these changes
Sep 28, 2024
Thompson1985
approved these changes
Sep 28, 2024
Thompson1985
approved these changes
Sep 28, 2024
Thompson1985
approved these changes
Sep 28, 2024
Thompson1985
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs included:
tools-editor-ideatotools-editor-rover#1916Relevant staging links: