Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /governance/teams/release redirect #1929

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 25, 2024

The release team was moved to an infra subteam. This caused existing blogpost links to fail since the server is not aware of this change. This commit fixes the issue by adding an explicit redirect.

Resolves rust-lang/blog.rust-lang.org#1246

r? @rust-lang/website

This allows us to use them in redirects regardless of the locale.
@Turbo87 Turbo87 requested a review from a team as a code owner February 25, 2024 10:12
Copy link
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the URLs form, e.g. /governance/teams/infra#Release team to /governance/teams/infra#team-release, which I think is great.

It's kinda broken for the localized version anyway: /es/governance/teams/infra#Equipo de <em>release</em> (Spanish)

@Manishearth
Copy link
Member

r+ but needs formatting

The `release` team was moved to an `infra` subteam. This caused existing blogpost links to fail since the server is not aware of this change. This commit fixes the issue by adding an explicit redirect.
@Turbo87 Turbo87 force-pushed the fix-release-team-url branch from 36f1764 to 863154f Compare February 25, 2024 17:26
@Turbo87
Copy link
Member Author

Turbo87 commented Feb 25, 2024

oops, sorry! I missed the failed lint job 😅

should be fixed now :)

@Manishearth Manishearth merged commit 8f0e38f into rust-lang:master Feb 26, 2024
1 check passed
@ehuss ehuss mentioned this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Team link is broken
3 participants