Fix some team page rendering issues #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust-lang/team#1403 we ended up doing things a little differently so that the top-level teams are not subteams of the council. This removes the check added in rust-lang#1937. This helps fix an issue where we do have some actual subteams of the council (like social-media), and we don't want those to show up on the main page.
This changes it so that the subteam flattening logic will look at all team kinds, not just "Team". This fixes it so that https://www.rust-lang.org/governance/teams/launching-pad will show all the sub-groups of embedded for example.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two fixes for the team pages: