Update textile to v4, remove old parsers #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onli
changed the title
|
Merged to facilitate testing by @bauigel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the textile plugin to only include the current version of the parser (marked as compatible with PHP >= 5.3, but I did not test that) via composer. It also removes the old textile parser we included as lib1, lib2 and lib3, partly under the assumption that they won't work with current PHP versions anyway.
Note that the approach of bundling the textile parser in the plugin directory is debatable. Why do this for a core plugin, isn't that the job of bundled_libs/? On the other hand, should this plugin be a core plugin in the first place? Textile seems to have fallen out of favor
Related to #847, reporting incompatibility notices with PHP 8.1.