Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyLBCollectorのcert_info, cert_expireのテストを実装 #215

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

hekki
Copy link
Member

@hekki hekki commented Dec 20, 2024

背景

#212 にてProxyLBCollectorで利用しているcryptoのアップデートが来ています。

ProxyLBCollectorにおいてcryptoは証明書ののパース処理に利用されており、cyptoのアップデート前に現在のバージョンで動作するテストを実装します。

変更点

ProxyLBCollectorのcert_info, cert_expireのテストを実装しました。証明書に関してはテスト用のオレオレ証明書を作成して利用しました。

動作確認

  • CIが通ること

Copy link
Member

@yamamoto-febc yamamoto-febc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hekki hekki merged commit 5373cdf into master Dec 20, 2024
13 checks passed
@hekki hekki deleted the test-cert branch December 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants