Monitor System DNS client queries #1426
Conversation
|
|
||
| // loop fetches new events and send them to via the Loki client. | ||
| func (t *Subscription) ReadWorker() { | ||
| t.ready = true |
There was a problem hiding this comment.
Comment needs to be updated
| sigEvent, err := windows.CreateEvent(nil, 0, 0, nil) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer windows.CloseHandle(sigEvent) |
There was a problem hiding this comment.
Why do we need this? sigEvent is not used anymore in the function body.
| if err != nil { | ||
| if err != win_eventlog.ERROR_NO_MORE_ITEMS { |
| eventLogName string | ||
| eventLogQuery string | ||
|
|
||
| ready bool |
There was a problem hiding this comment.
ready is never read anywhere so I guess we can drop it.
| t.wg.Add(1) | ||
| interval := time.NewTicker(time.Second) | ||
| defer func() { | ||
| t.ready = false | ||
| t.wg.Done() | ||
| interval.Stop() | ||
| }() |
There was a problem hiding this comment.
I guess ReadWorker is expected to run in a goroutine. so access to read is unprotected if it's launched multiple times.
Also, wg.Add(1) should be called before the go-routine is launched since there could be a race condition when starting the ReadWorker and immediatley calling Stop which could cause a panic. See https://pkg.go.dev/sync#WaitGroup.Add.
Better add a dedicated Start() routine that adds to the wg and kicks of the goroutine
This feature adds monitoring capabilities for the system DNS client.
How?
Windows: Windows Events subcription on the DNS Client
Linux: DBUS monitoring of systemd-resolved
This will allow Portmaster to disable the Secure DNS, while keeping DNS insights.