Revamped verdict handling #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaavi
reviewed
Mar 5, 2024
| @@ -722,22 +714,15 @@ func (conn *Connection) SetVerdict(newVerdict Verdict, reason, reasonOptionKey s | |||
| return true // TODO: remove | |||
| } | |||
|
|
|||
| // SetVerdictDirectly sets the firewall verdict. | |||
| // SetVerdictDirectly sets the verdict. | |||
| func (conn *Connection) SetVerdictDirectly(newVerdict Verdict) { | |||
There was a problem hiding this comment.
I think we can rename this to SetVerdict, because we don't need a distinction anymore.
Comment on lines
+758
to
+759
| // this is already handled when the connection tunnel has been | ||
| // established. |
There was a problem hiding this comment.
Not sure what this means, maybe it'll become clear later in the review.
There was a problem hiding this comment.
The ConnectionEstablished field is set when the tunnel actually got established
dhaavi
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.