[fix] SPN - Improve sticky domain handling in getStickiedHub function

[stenya]

It looks like getStickiedHub() has never worked as expected for stickyDomains.

Summary by CodeRabbit

• Refactor
  • Enhanced internal code clarity by separating variable initialization for improved maintainability.
  • Added documentation notes to flag potential improvements in domain handling for future updates.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes refactor the variable declaration in the getStickiedHub function within spn/crew/sticky.go. Previously, ok was declared and assigned in a single statement; now, it is explicitly declared as a boolean before being assigned a value from the stickyDomains map. Additionally, a comment was added in the avoidDestinationHub function to raise a question regarding whether the domain should also be avoided. No modifications in logic or alterations to exported entities have been introduced.

Changes

File(s)	Change Summary
spn/crew/sticky.go	Split the combined declaration and assignment of ok into separate statements in getStickiedHub; added a comment in avoidDestinationHub for future consideration.

Suggested reviewers

• vlabo
• Chiassonastraypatrick
• dhaavi

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdca991 and fe8a560.

📒 Files selected for processing (1)

• spn/crew/sticky.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Test & Build

🔇 Additional comments (2)

spn/crew/sticky.go (2)

74-75: Improved variable declaration and assignment

The refactoring to explicitly declare ok as a boolean before assignment is a good practice. This change makes the code more explicit about the variable type and avoids potential shadowing issues, which is particularly important in Go where := can both declare and assign variables.

---

151-151: Valid question about domain avoidance

This is a good question to raise. Currently, stickDestinationToHub() handles both IPs and domains, but avoidDestinationHub() only handles IPs. For consistency, it might make sense to also avoid domains when a hub is problematic. This would ensure that both sticky mechanisms have consistent behavior.

Would you like to implement this feature in a follow-up PR? Alternatively, we could add a more detailed comment explaining why domains are treated differently than IPs in the avoidance logic.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.