Fixes for the security audit #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,25 +1,25 @@ | |||
| module github.com/sagaxyz/ssc | |||
|
|
|||
| go 1.22.2 | |||
| go 1.22.7 | |||
There was a problem hiding this comment.
This should be consistent with the dockerfile. Why having two different ones?
| @@ -18,6 +18,10 @@ COPY --from=build-env /root/build/sscd /usr/bin/ | |||
|
|
|||
| RUN apk add gcompat bash curl | |||
|
|
|||
| RUN addgroup -S sscd && adduser -S sscd -G sscd | |||
| USER sscd | |||
| WORKDIR /home/sscd | |||
There was a problem hiding this comment.
Wait, this is a breaking change and will require a migration. Is it worth? If so, we will need to update the guides and everywhere we are using docker. Basically, current validators running as root have all the files under /root/.ssc. If you change the home that directory will be empty.
There was a problem hiding this comment.
Yep, it's not worth to do now so I closed this PR, we have more than enough to do without it.
|
I realized after that this was closed. Just making sure you are not merging the same changes elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update covers:
sscdfrom unprivileged user