SAK-49700 Assignments grades entered in GB not displayed in Assignments #12332
Conversation
|
@hornersa This is ok to do but you do make sure that it is backwards compatible so it should still work with existing associations. |
|
This PR does not attempt any backwards compatibility. I reported the broader backwards compatibility issue for ASN-GB associations last July, with the following Critical priority jira: https://sakaiproject.atlassian.net/browse/SAK-49097. After not seeing any response to that jira for a few months, I wrote a PHP script for local use to run after the SQL update scripts to modify DB records for relevant Assignment properties to accommodate to the new use of GB item ID prevalent in Sakai 23 code. Is there backwards compatibility implemented elsewhere in Sakai 23/24 for these ASN-GB associations that I may have missed? |
|
@hornersa I converted this to a draft while there is further discussion. |
ern
changed the title
| public Optional<Assignment> getAssignmentForGradebookLink(String context, String linkId) throws IdUnusedException, PermissionException { | ||
| if (StringUtils.isNoneBlank(context, linkId)) { | ||
| public Optional<Assignment> getAssignmentForGradebookLink(String context, Long linkId) throws IdUnusedException, PermissionException { | ||
| if (StringUtils.isNoneBlank(context) && linkId != null) { |
There was a problem hiding this comment.
| if (StringUtils.isNoneBlank(context) && linkId != null) { | |
| if (StringUtils.isNotBlank(context) && linkId != null) { |
|
@hornersa I don't think this PR can be accepted as is. A conversion SQL script would be needed. otherwise it needs to be compatible with both String and Long linkIds. |
|
@ern - To expedite a solution to this jira while also managing the related issues pertaining to backwards compatibility, SQL script updates, etc., I think it might to close this PR and let someone else take over this solution's development. The above is not something I can commit to at the moment. I'll proceed to remove myself as Assignee to the jira. |
Jira: https://sakaiproject.atlassian.net/browse/SAK-49700
The proposed fix conforms to the change introduced with Sakai 23, whereby the association between Assignments and GB items created in GB are now based on the GB item's ID instead of the GB item's name/title as before.