Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse schema version when processing saleor webhook #341

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Feb 28, 2024

Fix wrong logic introduced in 0.49.0: there is not header saleor-schema-version when app-sdk is processing saleor webhook. This header is only present on install request.

Now app-sdk will try to parse version from version field on GraphQL subscription Event. If field is not present null will be returned.

Copy link

changeset-bot bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: 9e3d0cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.49.1

Install it with

pnpm add @saleor/app-sdk@0.49.1

Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240228150605

Install it with

pnpm add @saleor/app-sdk@0.0.0-pr-20240228150605

Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240229095552

Install it with

pnpm add @saleor/app-sdk@0.0.0-pr-20240229095552

Copy link
Contributor

Package Line Rate Branch Rate Complexity Health
src 79% 93% 0
src.APL 85% 85% 0
src.APL.saleor-cloud 75% 86% 0
src.APL.vercel-kv 54% 69% 0
src.app-bridge 88% 86% 0
src.handlers.next 90% 85% 0
src.handlers.next.saleor-webhooks 94% 80% 0
src.middleware 60% 97% 0
src.settings-manager 96% 89% 0
src.test-utils 100% 90% 0
src.util 82% 100% 0
Summary 83% (3815 / 4581) 87% (453 / 522) 0

@krzysztofzuraw krzysztofzuraw changed the title [WIP] Parse schema version Parse schema version when processing saleor webhook Feb 29, 2024
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review February 29, 2024 09:59
@krzysztofzuraw krzysztofzuraw requested review from a team and lkostrowski February 29, 2024 09:59
@krzysztofzuraw krzysztofzuraw merged commit 8789f37 into main Feb 29, 2024
5 checks passed
@krzysztofzuraw krzysztofzuraw deleted the add-schema-version branch February 29, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants