Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark middlewares as deprecated #395

Closed
wants to merge 7 commits into from
Closed

Conversation

witoszekdev
Copy link
Member

Marked middlewares as deprecated in favor of handlers

@witoszekdev witoszekdev requested a review from a team as a code owner January 28, 2025 11:53
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 0ae361c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (cd902b5) to head (0ae361c).
Report is 3 commits behind head on v0.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             v0.x     #395      +/-   ##
==========================================
- Coverage   73.37%   73.04%   -0.33%     
==========================================
  Files          79       78       -1     
  Lines        3061     3024      -37     
  Branches      457      454       -3     
==========================================
- Hits         2246     2209      -37     
  Misses        810      810              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just remove them in main

"@saleor/app-sdk": patch
---

Marked `/middleware`s as deprecated in favor of `/handlers`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are merging this to main branch, which is 1.0.0 pre and will have breaking change. You can just remove them now, no need to deprecation.

Deprecation makes sense in v0.x branch

Copy link
Member Author

@witoszekdev witoszekdev Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I set wrong base branch 👍🏻

@witoszekdev witoszekdev changed the base branch from main to v0.x January 28, 2025 13:56
@witoszekdev
Copy link
Member Author

Opened another PR to fix this: #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants