-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark middlewares as deprecated #395
Conversation
🦋 Changeset detectedLatest commit: 0ae361c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.x #395 +/- ##
==========================================
- Coverage 73.37% 73.04% -0.33%
==========================================
Files 79 78 -1
Lines 3061 3024 -37
Branches 457 454 -3
==========================================
- Hits 2246 2209 -37
Misses 810 810
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just remove them in main
"@saleor/app-sdk": patch | ||
--- | ||
|
||
Marked `/middleware`s as deprecated in favor of `/handlers` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are merging this to main branch, which is 1.0.0 pre and will have breaking change. You can just remove them now, no need to deprecation.
Deprecation makes sense in v0.x branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, I set wrong base branch 👍🏻
Opened another PR to fix this: #397 |
Marked middlewares as deprecated in favor of handlers