Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handlers folder structure #396

Closed
wants to merge 13 commits into from
Closed

Conversation

witoszekdev
Copy link
Member

@witoszekdev witoszekdev commented Jan 28, 2025

  • Separated shared types to separate shared folder
  • Moved platform handlers to platform folder, leaving public imports unchanged
  • Added re-exports in platform/next for backwards compatibility (to be removed in v1)
  • Added @/ alias, updated tests to support it

@witoszekdev witoszekdev requested a review from a team as a code owner January 28, 2025 13:55
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 10f462f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 65.60000% with 43 lines in your changes missing coverage. Please review.

Project coverage is 73.67%. Comparing base (cd902b5) to head (10f462f).
Report is 3 commits behind head on v0.x.

Files with missing lines Patch % Lines
...andlers/platforms/next/create-protected-handler.ts 3.12% 31 Missing ⚠️
src/handlers/shared/index.ts 0.00% 5 Missing and 1 partial ⚠️
...handlers/platforms/next/create-manifest-handler.ts 79.16% 5 Missing ⚠️
src/handlers/platforms/next/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v0.x     #396      +/-   ##
==========================================
+ Coverage   73.37%   73.67%   +0.29%     
==========================================
  Files          79       84       +5     
  Lines        3061     3073      +12     
  Branches      457      458       +1     
==========================================
+ Hits         2246     2264      +18     
+ Misses        810      804       -6     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@witoszekdev witoszekdev marked this pull request as draft January 28, 2025 14:02
@witoszekdev witoszekdev changed the base branch from main to v0.x January 28, 2025 14:04
@witoszekdev witoszekdev force-pushed the add-new-handlers-logic branch from ed075ab to b5ae397 Compare January 28, 2025 14:13
@witoszekdev witoszekdev marked this pull request as ready for review January 28, 2025 14:13
@witoszekdev
Copy link
Member Author

FYI: Codecov is calculated incorrectly, because we haven't added new code, rather moving it to different place ;)

@witoszekdev
Copy link
Member Author

Closed, since we don't actually need this changes for v0, we'll have a migration guide prepared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant