Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changeset, add more description for changes #406

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

witoszekdev
Copy link
Member

  • Add missing changeset
  • Update changesets description, change scope

@witoszekdev witoszekdev requested a review from a team as a code owner February 10, 2025 13:50
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 685a685

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.64%. Comparing base (853abaa) to head (685a685).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   82.64%   82.64%           
=======================================
  Files          95       95           
  Lines        3497     3497           
  Branches      587      587           
=======================================
  Hits         2890     2890           
  Misses        600      600           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This example uses Next.js app router

```ts
/* /app/api/manifest/route.ts */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: can you add imports as well for createManifestHandler and createAppRegisterHandler


### Previously:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add ts to code block here to enable syntax highlighting


### Now:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add ts to code block here to enable syntax highlighting


Example request:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here you can use http to enable syntax highlighting

@witoszekdev witoszekdev merged commit 9bbaac2 into main Feb 11, 2025
9 checks passed
@witoszekdev witoszekdev deleted the add-missing-changeset branch February 11, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants