Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APL exports #410

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Update APL exports #410

merged 1 commit into from
Feb 20, 2025

Conversation

lkostrowski
Copy link
Member

Exports are now in dedicated import paths allowing tree shaking
APL interface do not require "isConfigured" and "isReady" anymore

@lkostrowski lkostrowski requested a review from a team as a code owner February 19, 2025 09:34
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: a16dae8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 65.78947% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (0a917ac) to head (a16dae8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/APL/saleor-cloud/saleor-cloud-apl.ts 42.85% 4 Missing ⚠️
src/APL/upstash/upstash-apl.ts 50.00% 3 Missing ⚠️
src/APL/env/env-apl.ts 60.00% 2 Missing ⚠️
src/handlers/actions/register-action-handler.ts 86.66% 2 Missing ⚠️
src/APL/env/index.ts 0.00% 0 Missing and 1 partial ⚠️
src/APL/upstash/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   82.61%   83.45%   +0.83%     
==========================================
  Files          95       98       +3     
  Lines        3498     3451      -47     
  Branches      587      592       +5     
==========================================
- Hits         2890     2880      -10     
+ Misses        601      560      -41     
- Partials        7       11       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkostrowski lkostrowski merged commit a915771 into main Feb 20, 2025
10 checks passed
@lkostrowski lkostrowski deleted the update-deps-3 branch February 20, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants