Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exported paths, added NextAppRouter specific platform #418

Merged
merged 9 commits into from
Mar 6, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove auth/browser
  • Loading branch information
lkostrowski committed Mar 4, 2025
commit 82fb0d161b2fc05c2176c8c5073bb83236c8b25c
13 changes: 4 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
@@ -183,15 +183,10 @@
"import": "./saleor-app.mjs",
"require": "./saleor-app.js"
},
"./auth/node": {
"types": "./auth/node.index.d.ts",
"import": "./auth/node/index.mjs",
"require": "./auth/node/index.js"
},
"./auth/browser": {
"types": "./auth/node.index.d.ts",
"import": "./auth/node/index.mjs",
"require": "./auth/node/index.js"
"./auth": {
"types": "./auth/index.d.ts",
"import": "./auth/index.mjs",
"require": "./auth/index.js"
},
"./headers": {
"types": "./headers.d.ts",
1 change: 0 additions & 1 deletion src/auth/browser/index.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { SpanKind, SpanStatusCode } from "@opentelemetry/api";
import { SemanticAttributes } from "@opentelemetry/semantic-conventions";

import { getJwksUrlFromSaleorApiUrl } from "@/auth/node/index";
import { getJwksUrlFromSaleorApiUrl } from "@/auth/index";

import { getOtelTracer, OTEL_CORE_SERVICE_NAME } from "../../open-telemetry";
import { getOtelTracer, OTEL_CORE_SERVICE_NAME } from "../open-telemetry";

export const fetchRemoteJwks = async (saleorApiUrl: string) => {
const tracer = getOtelTracer();
@@ -32,6 +32,6 @@
} finally {
span.end();
}
},

Check warning on line 35 in src/auth/fetch-remote-jwks.ts

Codecov / codecov/patch

src/auth/fetch-remote-jwks.ts#L35

Added line #L35 was not covered by tests
);
};
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createDebug } from "../../debug";
import { Permission } from "../../types";
import { createDebug } from "../debug";
import { Permission } from "../types";
import { DashboardTokenPayload } from "./verify-jwt";

const debug = createDebug("checkJwtPermissions");
1 change: 1 addition & 0 deletions src/auth/node/index.ts → src/auth/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export { verifyJWT } from "./verify-jwt";
export { getJwksUrlFromSaleorApiUrl, verifySignatureWithJwks } from "./verify-signature";
File renamed without changes.
6 changes: 3 additions & 3 deletions src/auth/browser/verify-jwt.ts → src/auth/verify-jwt.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import * as jose from "jose";

import { getJwksUrlFromSaleorApiUrl } from "@/auth/node";
import { getJwksUrlFromSaleorApiUrl } from "@/auth/index";

import { createDebug } from "../../debug";
import { Permission } from "../../types";
import { createDebug } from "../debug";
import { Permission } from "../types";
import { hasPermissionsInJwtToken } from "./has-permissions-in-jwt-token";
import { verifyTokenExpiration } from "./verify-token-expiration";

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as jose from "jose";

import { createDebug } from "../../debug";
import { createDebug } from "../debug";

const debug = createDebug("verify-signature");

File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createDebug } from "../../debug";
import { createDebug } from "../debug";
import { DashboardTokenPayload } from "./verify-jwt";

const debug = createDebug("verify-token-expiration");
2 changes: 1 addition & 1 deletion src/handlers/actions/register-action-handler.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { beforeEach, describe, expect, it, vi } from "vitest";

import * as fetchRemoteJwksModule from "@/auth/node/fetch-remote-jwks";
import * as fetchRemoteJwksModule from "@/auth/fetch-remote-jwks";
import * as getAppIdModule from "@/get-app-id";
import { SALEOR_API_URL_HEADER } from "@/headers";
import { MockAdapter } from "@/test-utils/mock-adapter";
2 changes: 1 addition & 1 deletion src/handlers/actions/register-action-handler.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable max-classes-per-file */
import { APL, AuthData } from "@/APL";
import { fetchRemoteJwks } from "@/auth/node/fetch-remote-jwks";
import { fetchRemoteJwks } from "@/auth/fetch-remote-jwks";
import { createDebug } from "@/debug";
import { getAppId } from "@/get-app-id";
import { SALEOR_API_URL_HEADER } from "@/headers";
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ import type { APIGatewayProxyEventV2 } from "aws-lambda";
import { beforeEach, describe, expect, it, vi } from "vitest";

import { AuthData } from "@/APL";
import * as fetchRemoteJwksModule from "@/auth/node/fetch-remote-jwks";
import * as fetchRemoteJwksModule from "@/auth/fetch-remote-jwks";
import * as getAppIdModule from "@/get-app-id";
import { SALEOR_API_URL_HEADER } from "@/headers";
import { MockAPL } from "@/test-utils/mock-apl";
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { beforeEach, describe, expect, it, vi } from "vitest";

import { AuthData } from "@/APL";
import * as fetchRemoteJwksModule from "@/auth/node/fetch-remote-jwks";
import * as fetchRemoteJwksModule from "@/auth/fetch-remote-jwks";
import * as getAppIdModule from "@/get-app-id";
import { SALEOR_API_URL_HEADER } from "@/headers";
import { MockAPL } from "@/test-utils/mock-apl";
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ import { createMocks } from "node-mocks-http";
import { beforeEach, describe, expect, it, Mock, vi } from "vitest";

import { APL, AuthData } from "@/APL";
import * as fetchRemoteJwksModule from "@/auth/node/fetch-remote-jwks";
import * as fetchRemoteJwksModule from "@/auth/fetch-remote-jwks";
import * as getAppIdModule from "@/get-app-id";
import { SALEOR_API_URL_HEADER } from "@/headers";
import { MockAPL } from "@/test-utils/mock-apl";
2 changes: 1 addition & 1 deletion src/handlers/shared/protected-action-validator.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { beforeEach, describe, expect, it, vi } from "vitest";

import * as verifyJWTModule from "@/auth/browser/verify-jwt";
import * as verifyJWTModule from "@/auth/verify-jwt";
import { SALEOR_API_URL_HEADER, SALEOR_AUTHORIZATION_BEARER_HEADER } from "@/headers";
import { MockAdapter } from "@/test-utils/mock-adapter";
import { MockAPL } from "@/test-utils/mock-apl";
2 changes: 1 addition & 1 deletion src/handlers/shared/protected-action-validator.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { SpanKind, SpanStatusCode } from "@opentelemetry/api";

import { APL, AuthData } from "@/APL";
import { verifyJWT } from "@/auth/browser/verify-jwt";
import { verifyJWT } from "@/auth/verify-jwt";
import { createDebug } from "@/debug";
import { getOtelTracer } from "@/open-telemetry";
import { Permission } from "@/types";
4 changes: 2 additions & 2 deletions src/handlers/shared/saleor-webhook-validator.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { beforeEach, describe, expect, it, vi } from "vitest";

import { AuthData } from "@/APL";
import * as fetchRemoteJwksModule from "@/auth/node/fetch-remote-jwks";
import * as verifySignatureModule from "@/auth/node/verify-signature";
import * as fetchRemoteJwksModule from "@/auth/fetch-remote-jwks";
import * as verifySignatureModule from "@/auth/verify-signature";
import { MockAdapter } from "@/test-utils/mock-adapter";
import { MockAPL } from "@/test-utils/mock-apl";

4 changes: 2 additions & 2 deletions src/handlers/shared/saleor-webhook-validator.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { SpanKind, SpanStatusCode } from "@opentelemetry/api";

import { APL } from "@/APL";
import { fetchRemoteJwks } from "@/auth/node/fetch-remote-jwks";
import { verifySignatureWithJwks } from "@/auth/node/verify-signature";
import { fetchRemoteJwks } from "@/auth/fetch-remote-jwks";
import { verifySignatureWithJwks } from "@/auth/verify-signature";
import { createDebug } from "@/debug";
import { getOtelTracer } from "@/open-telemetry";
import { SaleorSchemaVersion } from "@/types";
3 changes: 1 addition & 2 deletions tsup.config.ts
Original file line number Diff line number Diff line change
@@ -28,8 +28,7 @@ export default defineConfig({
"handlers/fetch-api/index": "src/handlers/platforms/fetch-api/index.ts",
"handlers/aws-lambda/index": "src/handlers/platforms/aws-lambda/index.ts",
"handlers/next-app-router/index": "src/handlers/platforms/next-app-router/index.ts",
"auth/node/index": "src/auth/node/index.ts",
"auth/browser/index": "src/auth/browser/index.ts",
"auth/node/index": "src/auth/index.ts",
},
dts: true,
clean: true,
Loading