-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require deleteMetadata to metadata manager #419
Conversation
🦋 Changeset detectedLatest commit: 9165c95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 81.66% 82.11% +0.45%
==========================================
Files 107 107
Lines 3502 3501 -1
Branches 593 594 +1
==========================================
+ Hits 2860 2875 +15
+ Misses 626 610 -16
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/** | ||
* Keep it optional, to avoid breaking changes. If not provided, delete will throw. | ||
* TODO: Make it required in next major version | ||
*/ | ||
deleteMetadata?: DeleteMetadataCallback; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: shouldn't we make it required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes XD
No description provided.