Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PNPM to latest version #731

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Conversation

NyanKiyoshi
Copy link
Member

@NyanKiyoshi NyanKiyoshi commented Dec 13, 2024

The PNPM version was ancient (released ~4 years ago) thus it commit upgrades it to the latest version. This also helps us ensure consistency in our package managers and JS/TS projects across our organization.

Changes were tested locally:

  • pnpm build
  • pnpm test
  • pnpm lint

Changes made:

  • GitHub Workflows:
    • Upgraded actions/setup-node and pnpm/action-setup version to latest (to ensure compatibility with more recent engines and to fix techdebt)
    • Removed explicit version field for pnpm/action-setup, instead it will read packageManager field in the package.json
  • Project: upgraded PNPM version to latest, removed support for Node.js v16 (due to being EOL and PNPM not supporting that version anymore)

I have:

  • Tested it locally and it doesn't break existing features
  • Added documentation if public changes are introduced
  • Added tests for my code

The PNPM version was ancient (released ~4 years ago) thus it commit upgrades it to the latest version. This also helps us ensure consistency in our package managers and JS/TS projects across our organization.
@NyanKiyoshi NyanKiyoshi requested a review from a team as a code owner December 13, 2024 10:24
@NyanKiyoshi NyanKiyoshi marked this pull request as draft December 13, 2024 10:35
@NyanKiyoshi
Copy link
Member Author

I see the CIs are failing, I will update them once I have time 👍

This upgrade the `pnpm/action-setup` action to latest, and removes the explicit `version` field in order to tell it to read `packageManager` field in the `package.json`.
Node.js v16 is not supported by latest version of PNPM, and Node.js 16 is EOL thus it is now removed in favor of v18.
@NyanKiyoshi NyanKiyoshi marked this pull request as ready for review February 18, 2025 11:46
@NyanKiyoshi NyanKiyoshi requested a review from a team as a code owner February 18, 2025 11:46
@NyanKiyoshi NyanKiyoshi merged commit 0ae533a into saleor:main Feb 20, 2025
4 checks passed
@NyanKiyoshi NyanKiyoshi deleted the deps/update-pnpm branch February 20, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants