test(map): verify map.jinja dump using _mapdata state
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Automated using myii/ssf-formula#283
myii
force-pushed
the
test/manage-map.jinja-verification
branch
from
067d30f to
f88fdf7
Compare
Use method: 1. `rubocop -a --safe` 2. `rubocop -A --safe` 3. Use `rubocop:disable` ``` Offenses: test/integration/default/controls/config_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment. control 'Php configuration' do ^ test/integration/default/controls/config_spec.rb:4:3: C: Metrics/AbcSize: Assignment Branch Condition size for test_debian is too high. [<0, 26, 0> 26/17] (http://c2.com/cgi/wiki?AbcMetric, https://en.wikipedia.org/wiki/ABC_Software_Metric) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/config_spec.rb:4:3: C: Metrics/MethodLength: Method has too many lines. [14/10] (https://rubystyle.guide#short-methods) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/config_spec.rb:24:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_redhat ... ^^^^^^^^^^^^^^^ test/integration/default/controls/config_spec.rb:27:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_suse ... ^^^^^^^^^^^^^ test/integration/default/controls/package_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment. control 'Php package' do ^ test/integration/default/controls/package_spec.rb:4:3: C: Metrics/AbcSize: Assignment Branch Condition size for test_debian is too high. [<1, 26, 1> 26.04/17] (http://c2.com/cgi/wiki?AbcMetric, https://en.wikipedia.org/wiki/ABC_Software_Metric) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/package_spec.rb:4:3: C: Metrics/MethodLength: Method has too many lines. [20/10] (https://rubystyle.guide#short-methods) def test_debian ... ^^^^^^^^^^^^^^^ test/integration/default/controls/package_spec.rb:21:1: C: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. (https://rubystyle.guide#empty-lines-around-bodies) test/integration/default/controls/service_spec.rb:1:1: C: Style/FrozenStringLiteralComment: Missing frozen string literal comment. control 'Php service' do ^ test/integration/default/controls/service_spec.rb:16:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_redhat ... ^^^^^^^^^^^^^^^ test/integration/default/controls/service_spec.rb:19:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://rubystyle.guide#no-single-line-methods) def test_suse ... ^^^^^^^^^^^^^ 7 files inspected, 12 offenses detected, 8 offenses auto-correctable ```
myii
force-pushed
the
test/manage-map.jinja-verification
branch
from
7088f23 to
1a4d208
Compare
|
Self-merging since tests only. |
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
myii
added a commit
to myii/ssf-formula
that referenced
this pull request
Dec 23, 2020
`rubocop` already fixed during the previous PR: * saltstack-formulas/php-formula#221
myii
added a commit
to myii/ssf-formula
that referenced
this pull request
Dec 23, 2020
`rubocop` already fixed during the previous PR (#283): * saltstack-formulas/php-formula#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
map.jinjaverification myii/ssf-formula#283Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context