Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored .env for some services #46

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

RyanWalker277
Copy link
Collaborator

@RyanWalker277 RyanWalker277 commented Apr 21, 2023

Refs

Partial fix for #33

@gitguardian
Copy link

gitguardian bot commented Apr 21, 2023

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 33d0ea8 .env View secret
- Generic High Entropy Secret 33d0ea8 .env View secret
- Generic High Entropy Secret 33d0ea8 .env View secret
- Generic High Entropy Secret 0198b44 .env View secret
- Generic High Entropy Secret 0198b44 .env View secret
934781 Generic High Entropy Secret c67da57 .env View secret
934781 Generic High Entropy Secret c67da57 .env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@RyanWalker277 RyanWalker277 mentioned this pull request Apr 21, 2023
27 tasks
@tushar5526
Copy link
Collaborator

.env will still be there. Let's get on a call to explain more. I think there is some mis understanding.

@tushar5526
Copy link
Collaborator

tushar5526 commented Apr 25, 2023

Also, let's do this service by service, instead of one big PR. Also go more into different env blocks in docker compose
https://docs.docker.com/compose/environment-variables/envvars-precedence/

@RyanWalker277 RyanWalker277 changed the title Refactored .env Refactored .env for uci-api-db Apr 26, 2023
@RyanWalker277 RyanWalker277 force-pushed the env-refactoring branch 2 times, most recently from 3bc614c to c59e528 Compare May 2, 2023 19:37
@RyanWalker277 RyanWalker277 changed the title Refactored .env for uci-api-db Refactored .env for some services May 2, 2023
@RyanWalker277
Copy link
Collaborator Author

Hey @tushar5526. As an initial PR, I have covered a few services in this one and tried to finalaise them.Since these didn't have much env vars of their own, so I just restructured the env a bit and removed docker env-file attribute from all of them. I wasnt sure about the redis one but on testing I found out that it works just fine without the rest of the env vars, so they are'nt necessary for it's functioning. Do let me know if I missed something.



# Hasura formsdb
FORMSDB_HASURA_GRAPHQL_ADMIN_SECRET=4GeEB2JCU5rBdLvQ4AbeqqrPGu7kk9SZDhJUZm7A
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declared twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants