-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored .env for some services #46
base: dev
Are you sure you want to change the base?
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 33d0ea8 | .env | View secret |
- | Generic High Entropy Secret | 33d0ea8 | .env | View secret |
- | Generic High Entropy Secret | 33d0ea8 | .env | View secret |
- | Generic High Entropy Secret | 0198b44 | .env | View secret |
- | Generic High Entropy Secret | 0198b44 | .env | View secret |
934781 | Generic High Entropy Secret | c67da57 | .env | View secret |
934781 | Generic High Entropy Secret | c67da57 | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Also, let's do this service by service, instead of one big PR. Also go more into different env blocks in docker compose |
b939e56
to
c67da57
Compare
3bc614c
to
c59e528
Compare
uci-api-db
Hey @tushar5526. As an initial PR, I have covered a few services in this one and tried to finalaise them.Since these didn't have much env vars of their own, so I just restructured the env a bit and removed docker |
|
||
|
||
# Hasura formsdb | ||
FORMSDB_HASURA_GRAPHQL_ADMIN_SECRET=4GeEB2JCU5rBdLvQ4AbeqqrPGu7kk9SZDhJUZm7A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
declared twice
Refs
Partial fix for #33