Fixed Test - Adapter Service adapter.service.spec.ts
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devAyushDubey
changed the title
adapter.controller.service.tsadapter.service.spec.ts
chinmoy12c
reviewed
Jun 16, 2023
Comment on lines
31
to
62
| useValue: { | ||
| adapter: { | ||
| create: jest.fn(async (adapterDTO) => { | ||
| return { | ||
| id: 'mockID', | ||
| createdAt: 1000000000000, | ||
| updatedAt: 1000000000000, | ||
| channel: adapterDTO.data.channel, | ||
| provider: adapterDTO.data.provider, | ||
| config: adapterDTO.data.config, | ||
| name: adapterDTO.data.name, | ||
| }; | ||
| }), | ||
| findMany: jest.fn().mockReturnValue([ | ||
| { | ||
| ...mockAdapter, | ||
| }, | ||
| ]), | ||
| findUnique: jest.fn((filter) => { | ||
| const res = { ...mockAdapter }; | ||
| res.id = filter.where.id; | ||
| return res; | ||
| }), | ||
| update: jest.fn((payload) => { | ||
| return { | ||
| id: payload.where.id, | ||
| createdAt: 1000000000000, | ||
| updatedAt: 1000000000000, | ||
| ...payload.data, | ||
| }; | ||
| }), | ||
| }, |
There was a problem hiding this comment.
Can you extract the mock implementation above beforeEach? Looks a bit cleaner that way, as this mock implementation might increase in size later, as needed.
There was a problem hiding this comment.
Sure, can you review the recent changes. Thanks!
chinmoy12c
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentions #109
Tracked by #95