Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id and missing style on disabled checkbox #6966

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

jlhardes
Copy link
Contributor

@jlhardes jlhardes commented Nov 7, 2024

Fixes

Fixes #6778

Summary

Add id for disabled checkbox input

Type of change (for release notes)

  • notes-minor New Features that are backward compatible

Detailed Description

Adds id attribute on disabled checkbox input used in My Collections and All/Managed Collections for admin sets that are either the default admin set or are not deletable after items have been added. Assistive tech still needs info about a disabled checkbox to know what it is and the label was there but the input didn't include the id to match up to the label. Also My Collections was missing a style to align the disabled checkbox correctly so that was added.

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Nov 7, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 30s ⏱️ -8s
 6 729 tests +1   6 432 ✅ +1  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit dec55b5. ± Comparison against base commit 83413b6.

This pull request removes 273 and adds 274 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7722f212c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fcf08726698>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7722f26f48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fcf0a719ec8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 058378f3-5bb8-48f4-9196-8db2b80f8090
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2402ae0e-2d3b-46a4-9965-b3376bf90eeb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a5550cc8-c904-4559-a9eb-7f1c1d634077
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 1d3e9e45-7d81-4b06-81b5-1b206e11f71f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 7ee4ec34-1d62-4fb9-bd84-b2746c7bf553
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: a6f11e80-2499-4965-985a-aa952472a680
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4ed6837440>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f701e240f00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4ed683e100>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f701b34e620>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: c7480c5c-bd90-4827-a162-b91d9189828a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b0860098-915d-43ad-9b18-37b354d39c58
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: de1ab23f-1fd9-4281-8245-e0f99b022b0d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: d646e412-c3a3-455f-a75e-17670148caf5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 6339c687-3c7e-4f61-b8b0-507b761c352f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 13a7d5ba-35b3-4b68-90a7-7c2cdf5267a2
…

♻️ This comment has been updated with latest results.

@dlpierce dlpierce added the notes-accessibility Release Notes: Accessibility label Nov 8, 2024
@randalldfloyd randalldfloyd merged commit 5c07d4f into main Nov 8, 2024
23 checks passed
@randalldfloyd randalldfloyd deleted the issue-6778 branch November 8, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-accessibility Release Notes: Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed Collection checkboxes are missing labels
3 participants