Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to checkbox lists #6969

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add labels to checkbox lists #6969

merged 1 commit into from
Nov 8, 2024

Conversation

jlhardes
Copy link
Contributor

@jlhardes jlhardes commented Nov 8, 2024

Fixes

Fixes #6785

Summary

Adds labels to checkbox inputs

Type of change (for release notes)

  • notes-minor New Features that are backward compatible

Detailed Description

Makes same changes as #6964 to add labels around titles in checkbox lists and adds aria-labelledby attributes on checkbox input based on id value (although there is no Select All checkbox in this case). Also uses the batch_select/_add_button code change from other PR.

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Nov 8, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 15m 17s ⏱️ - 2m 23s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 153239f. ± Comparison against base commit faae072.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0a71297f98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fbd7d69b2d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0a714457a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbd810ebb90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 9393c420-cf43-4b30-8367-f11442f19a4a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: cacdcfc3-5041-44c3-93c8-b21d0e1a5e08
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 99660c3c-e8e1-4745-97e7-e2e00f50a36b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: d02ea0d5-56f3-4feb-8a6e-b4df8b617817
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: a9ef016d-7b16-436d-a7c2-cf0c9ec6247e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 540925ac-d9ae-4461-a89c-6886fa504e60
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0a44069258>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0a7e8221e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0a45674390>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0a85beaa00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 36a3300b-d0f3-43bb-b472-0d5ca1da37d0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b382caec-6e32-4b86-89bc-63e091f98cee
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: add20af3-d6fa-488a-b8a2-2e640ad1eff5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 9ba884f1-f85f-4c2a-af15-c832f5d90299
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 5b77d6ae-d4c0-4cd2-955b-a9af12681781
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 05ed7ec2-ca94-4491-a816-0b1be5cdcdd4
…

@dlpierce dlpierce added the notes-accessibility Release Notes: Accessibility label Nov 8, 2024
@dlpierce dlpierce merged commit 0b593bb into main Nov 8, 2024
22 checks passed
@dlpierce dlpierce deleted the issue-6785 branch November 8, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-accessibility Release Notes: Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkboxes on Expired Active Leases page missing labels
2 participants