Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin concurrent-ruby #6989

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Pin concurrent-ruby #6989

merged 1 commit into from
Jan 22, 2025

Conversation

dlpierce
Copy link
Member

1.3.5 exposes rails bug that is fixed in rails 7

Fixes

Fixes hyrax not starting due to uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

1.3.5 exposes rails bug that is fixed in rails 7
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

Test Results

    13 files  ±0      13 suites  ±0   3h 0m 29s ⏱️ + 1m 51s
 6 836 tests +4   6 532 ✅ ±0  299 💤 ±0  5 ❌ +4 
18 100 runs  ±0  17 618 ✅  - 4  477 💤 ±0  5 ❌ +4 

For more details on these failures, see this check.

Results for commit a74a1b2. ± Comparison against base commit 3788d40.

This pull request removes 367 and adds 371 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f06e9353ad0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7dbd9ab540>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f872ae70c80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f06e869e4c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7dbd012a88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f872d0d3200>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 3cc3208a-e719-4560-96e7-2b01682af18d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 080e5f75-67ae-4a82-a716-83c72d6274ab
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: e21c8043-5652-40ed-9ba6-e6d0cdc8c69f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a9ea036b-e9f5-45b0-b9f5-474404349da7
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f039aa3e388>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8307a55780>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa1f70e7310>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f039b2e1198>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8308debba0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa1f6ce3700>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 9ac956ee-007a-43c5-899e-4a3f55113d6d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 17a5f764-6501-4e07-be68-e5f9892848c2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b1b6542c-04fd-4b4b-83f6-a6db0f526074
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 47c10514-7266-4281-b2af-772d13691b9b
…

♻️ This comment has been updated with latest results.

@randalldfloyd randalldfloyd merged commit 2c73a9b into main Jan 22, 2025
14 of 17 checks passed
@randalldfloyd randalldfloyd deleted the pin-concurrent-ruby branch January 22, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants