Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more overflow style overrides #6993

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Added more overflow style overrides #6993

merged 1 commit into from
Jan 23, 2025

Conversation

jlhardes
Copy link
Contributor

Fixes

Fixes #6789

Summary

Additional overflow style overrides for browser-specific SiteImprove errors

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • View Dashboard > Settings > Pages to see TinyMCE editor
  • Run SiteImprove plug-in and should not see any errors about "Text is clipped when resized"

Type of change (for release notes)

  • notes-minor New Features that are backward compatible

Detailed Description

SiteImprove is registering an accessibility error within the TinyMCE editor regarding text being clipped when the screen is resized. This was showing on Chrome on Mac for only the bottom status bar but it also is an issue in Chrome on Windows for the drop-down style menu. Adding overrides for (hopefully) all of the overflow: hidden styles to make them visible seems to not be disrupting things for the editor in Chrome on Mac. This change will need to be checked in Chrome on Windows (testing on pg.nurax, most likely) to know for sure that is fixes the accessibility issue and doesn't cause any other problems.

@samvera/hyrax-code-reviewers

Copy link

Test Results

    13 files  ±0      13 suites  ±0   3h 0m 37s ⏱️ - 4m 56s
 6 836 tests +4   6 532 ✅  - 1  299 💤 ±0  5 ❌ +5 
18 100 runs  ±0  17 618 ✅  - 5  477 💤 ±0  5 ❌ +5 

For more details on these failures, see this check.

Results for commit 9322f27. ± Comparison against base commit b46d95b.

This pull request removes 366 and adds 370 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3b26c6bf48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f448a843d40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f89619b8fd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3b267c0020>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f448afff8e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f89577b12d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: dc75f9df-d43c-4db6-adb8-3b2c9ffce74a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 8b7c9ff9-7ca3-4ced-854e-436fe526d74c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: e99b440c-0572-4275-a5bd-60dd4fe1d735
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 5e31ef56-440a-46cc-b03b-5129195a0ed9
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f148b9db1a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7edaa27fa0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb3789e8850>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f148b8e20a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7ed96d3940>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb3788a30d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 4b20b17f-e1e8-4f92-9e06-1e533b01a42b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 19731117-deac-4500-abe5-67826d4e0376
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 9741aecc-8e95-4300-80a1-13ee0d6ea7bc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 3ba2bf17-7932-4d7b-a923-d9648381673c
…

@randalldfloyd randalldfloyd merged commit 3c4a4b5 into main Jan 23, 2025
13 of 16 checks passed
@randalldfloyd randalldfloyd deleted the issue-6789 branch January 23, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple links on Pages page clip text when resized
2 participants