Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collection: Assign all non-role specific ("global") variables to role local variables #589

Closed
berndfinger opened this issue Jan 12, 2024 · 1 comment
Closed

collection: Assign all non-role specific ("global") variables to role local variables #589

berndfinger opened this issue Jan 12, 2024 · 1 comment
Assignees
@berndfinger

Comments

@berndfinger
Copy link
Member

We should no longer use "global" variables directly in a role but always assign them to local variables which follow the variable naming scheme, as in:

sap_ha_pacemaker_cluster_hana_sid: "{{ sap_hana_sid | d('') }}"

Note: When running ansible-lint in the collection root, we get var-naming[no-role-prefix] violations which are not detected when running ansible-lint in the role root.
@berndfinger berndfinger self-assigned this Jan 12, 2024
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Jan 12, 2024
@berndfinger
sap_general_preconfigure: skip var-naming[no-role-prefix]
dccd5a9 
... for the three variables sap_hostname, sap_domain, sap_ip.

Those are used in many places in the role and the effort for changing
and testing the code is too high given that we plan to replace this
part of the role by the new role sap_maintain_etc_hosts.

Relates to sap-linuxlab#589.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
@berndfinger berndfinger mentioned this issue Jan 12, 2024
Merged
@berndfinger
Copy link
Member Author

Solved for now in #591.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berndfinger berndfinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berndfinger